Magento 2 get quantity of product in cart without loop












1















I have written a controller in Magento 2 that adds products to the logged in users account.



The controller is working properly however i am facing a slight issue.



You cannot add a product to your cart with a greater quantity than what is in stock. so you cannot add a quantity of 6 if there are only 5 in stock, this results in a 500 error. to get around this I am using this:



if($QuantityToAdd > $ProductStock){
// throw error
}
else{
// add to cart
}


and this is working fine for the scenario above.



however, this will also allow the user to add 4 products, and then try to add another 2 products separately. This will again result in a 500 error, stating:




main.ERROR: We don't have as many "XXXX" as you requested.




in the logs.



So I added a foreach, on the current cart items to get the quantity of that product already in the cart:



if(($QuantityToAdd + $QuantityInCart) > $ProductStock){
// throw error
}
else{
// add to cart
}


this solved my errors. However now the controller regularly times out as it will cycle the cart foreach within the add products for each, so if the user is trying to add 200 product variants and they already have 200 products in the cart, the controller will loop over 40,000 times.




200x200 = 40,000 loops




The quantities mentioned here are potentially at the lower end of possible usage.



To optimise this I have found a function:



if ($this->checkoutSession->create()->getQuote()->hasProductId($productId)) {
//product is available in the cart
}


Without performing another foreach, or any kind of loop, is it possible to get the current quantity of the product in the cart, if the above if statement is true?



or alternatively,



$this->cart->addProduct($productToadd, $params);


is there a function that updates the product in the cart instead of adding the new quantity on to the existing quantity?



Thanks.



EDIT:



Foreach by request:



foreach($products as $purchase){
$productSku = $purchase['Sku'];
$qty = $purchase['Quantity'];

$loadedProduct = $this->getProductBySku($productSku);

$productStock = $this->stockRegistry->getStockItem($loadedProduct->getId());
$manageStock = $productStock->getData('manage_stock');

if($manageStock == "1"){
$productQty = $productStock->getQty();
$quantityInCart = 0;
$items = $this->cart->getQuote()->getAllItems();
$productId=$loadedProduct->getId();
foreach ($items as $item) {
if ($item->getProductId() == $productId) {
$quantityInCart = $quantityInCart + $item->getQty();
}
}
if($productStock->getBackorders() > 1){
if(($qty + $quantityInCart) > $productQty){
$this->_messageManager->addError(__("Failed to add " . $purchase['Name'] . " - " .$purchase['Option'] . " " . $productQty . " available"));
$return = $purchase['Name'] . " - " .$purchase['Option'] . " " . $productQty . " available";
$proceed = false;
$returnObject->success = false;
}
}
}
}


This foreach checks through each of the products the user is trying to add, if they are all fine, there is a second for each to add the products.










share|improve this question

























  • can you post the code that does the foreach in foreach ?

    – Marius
    16 mins ago











  • Edited the original post

    – vmp
    12 mins ago
















1















I have written a controller in Magento 2 that adds products to the logged in users account.



The controller is working properly however i am facing a slight issue.



You cannot add a product to your cart with a greater quantity than what is in stock. so you cannot add a quantity of 6 if there are only 5 in stock, this results in a 500 error. to get around this I am using this:



if($QuantityToAdd > $ProductStock){
// throw error
}
else{
// add to cart
}


and this is working fine for the scenario above.



however, this will also allow the user to add 4 products, and then try to add another 2 products separately. This will again result in a 500 error, stating:




main.ERROR: We don't have as many "XXXX" as you requested.




in the logs.



So I added a foreach, on the current cart items to get the quantity of that product already in the cart:



if(($QuantityToAdd + $QuantityInCart) > $ProductStock){
// throw error
}
else{
// add to cart
}


this solved my errors. However now the controller regularly times out as it will cycle the cart foreach within the add products for each, so if the user is trying to add 200 product variants and they already have 200 products in the cart, the controller will loop over 40,000 times.




200x200 = 40,000 loops




The quantities mentioned here are potentially at the lower end of possible usage.



To optimise this I have found a function:



if ($this->checkoutSession->create()->getQuote()->hasProductId($productId)) {
//product is available in the cart
}


Without performing another foreach, or any kind of loop, is it possible to get the current quantity of the product in the cart, if the above if statement is true?



or alternatively,



$this->cart->addProduct($productToadd, $params);


is there a function that updates the product in the cart instead of adding the new quantity on to the existing quantity?



Thanks.



EDIT:



Foreach by request:



foreach($products as $purchase){
$productSku = $purchase['Sku'];
$qty = $purchase['Quantity'];

$loadedProduct = $this->getProductBySku($productSku);

$productStock = $this->stockRegistry->getStockItem($loadedProduct->getId());
$manageStock = $productStock->getData('manage_stock');

if($manageStock == "1"){
$productQty = $productStock->getQty();
$quantityInCart = 0;
$items = $this->cart->getQuote()->getAllItems();
$productId=$loadedProduct->getId();
foreach ($items as $item) {
if ($item->getProductId() == $productId) {
$quantityInCart = $quantityInCart + $item->getQty();
}
}
if($productStock->getBackorders() > 1){
if(($qty + $quantityInCart) > $productQty){
$this->_messageManager->addError(__("Failed to add " . $purchase['Name'] . " - " .$purchase['Option'] . " " . $productQty . " available"));
$return = $purchase['Name'] . " - " .$purchase['Option'] . " " . $productQty . " available";
$proceed = false;
$returnObject->success = false;
}
}
}
}


This foreach checks through each of the products the user is trying to add, if they are all fine, there is a second for each to add the products.










share|improve this question

























  • can you post the code that does the foreach in foreach ?

    – Marius
    16 mins ago











  • Edited the original post

    – vmp
    12 mins ago














1












1








1








I have written a controller in Magento 2 that adds products to the logged in users account.



The controller is working properly however i am facing a slight issue.



You cannot add a product to your cart with a greater quantity than what is in stock. so you cannot add a quantity of 6 if there are only 5 in stock, this results in a 500 error. to get around this I am using this:



if($QuantityToAdd > $ProductStock){
// throw error
}
else{
// add to cart
}


and this is working fine for the scenario above.



however, this will also allow the user to add 4 products, and then try to add another 2 products separately. This will again result in a 500 error, stating:




main.ERROR: We don't have as many "XXXX" as you requested.




in the logs.



So I added a foreach, on the current cart items to get the quantity of that product already in the cart:



if(($QuantityToAdd + $QuantityInCart) > $ProductStock){
// throw error
}
else{
// add to cart
}


this solved my errors. However now the controller regularly times out as it will cycle the cart foreach within the add products for each, so if the user is trying to add 200 product variants and they already have 200 products in the cart, the controller will loop over 40,000 times.




200x200 = 40,000 loops




The quantities mentioned here are potentially at the lower end of possible usage.



To optimise this I have found a function:



if ($this->checkoutSession->create()->getQuote()->hasProductId($productId)) {
//product is available in the cart
}


Without performing another foreach, or any kind of loop, is it possible to get the current quantity of the product in the cart, if the above if statement is true?



or alternatively,



$this->cart->addProduct($productToadd, $params);


is there a function that updates the product in the cart instead of adding the new quantity on to the existing quantity?



Thanks.



EDIT:



Foreach by request:



foreach($products as $purchase){
$productSku = $purchase['Sku'];
$qty = $purchase['Quantity'];

$loadedProduct = $this->getProductBySku($productSku);

$productStock = $this->stockRegistry->getStockItem($loadedProduct->getId());
$manageStock = $productStock->getData('manage_stock');

if($manageStock == "1"){
$productQty = $productStock->getQty();
$quantityInCart = 0;
$items = $this->cart->getQuote()->getAllItems();
$productId=$loadedProduct->getId();
foreach ($items as $item) {
if ($item->getProductId() == $productId) {
$quantityInCart = $quantityInCart + $item->getQty();
}
}
if($productStock->getBackorders() > 1){
if(($qty + $quantityInCart) > $productQty){
$this->_messageManager->addError(__("Failed to add " . $purchase['Name'] . " - " .$purchase['Option'] . " " . $productQty . " available"));
$return = $purchase['Name'] . " - " .$purchase['Option'] . " " . $productQty . " available";
$proceed = false;
$returnObject->success = false;
}
}
}
}


This foreach checks through each of the products the user is trying to add, if they are all fine, there is a second for each to add the products.










share|improve this question
















I have written a controller in Magento 2 that adds products to the logged in users account.



The controller is working properly however i am facing a slight issue.



You cannot add a product to your cart with a greater quantity than what is in stock. so you cannot add a quantity of 6 if there are only 5 in stock, this results in a 500 error. to get around this I am using this:



if($QuantityToAdd > $ProductStock){
// throw error
}
else{
// add to cart
}


and this is working fine for the scenario above.



however, this will also allow the user to add 4 products, and then try to add another 2 products separately. This will again result in a 500 error, stating:




main.ERROR: We don't have as many "XXXX" as you requested.




in the logs.



So I added a foreach, on the current cart items to get the quantity of that product already in the cart:



if(($QuantityToAdd + $QuantityInCart) > $ProductStock){
// throw error
}
else{
// add to cart
}


this solved my errors. However now the controller regularly times out as it will cycle the cart foreach within the add products for each, so if the user is trying to add 200 product variants and they already have 200 products in the cart, the controller will loop over 40,000 times.




200x200 = 40,000 loops




The quantities mentioned here are potentially at the lower end of possible usage.



To optimise this I have found a function:



if ($this->checkoutSession->create()->getQuote()->hasProductId($productId)) {
//product is available in the cart
}


Without performing another foreach, or any kind of loop, is it possible to get the current quantity of the product in the cart, if the above if statement is true?



or alternatively,



$this->cart->addProduct($productToadd, $params);


is there a function that updates the product in the cart instead of adding the new quantity on to the existing quantity?



Thanks.



EDIT:



Foreach by request:



foreach($products as $purchase){
$productSku = $purchase['Sku'];
$qty = $purchase['Quantity'];

$loadedProduct = $this->getProductBySku($productSku);

$productStock = $this->stockRegistry->getStockItem($loadedProduct->getId());
$manageStock = $productStock->getData('manage_stock');

if($manageStock == "1"){
$productQty = $productStock->getQty();
$quantityInCart = 0;
$items = $this->cart->getQuote()->getAllItems();
$productId=$loadedProduct->getId();
foreach ($items as $item) {
if ($item->getProductId() == $productId) {
$quantityInCart = $quantityInCart + $item->getQty();
}
}
if($productStock->getBackorders() > 1){
if(($qty + $quantityInCart) > $productQty){
$this->_messageManager->addError(__("Failed to add " . $purchase['Name'] . " - " .$purchase['Option'] . " " . $productQty . " available"));
$return = $purchase['Name'] . " - " .$purchase['Option'] . " " . $productQty . " available";
$proceed = false;
$returnObject->success = false;
}
}
}
}


This foreach checks through each of the products the user is trying to add, if they are all fine, there is a second for each to add the products.







magento2 cart addtocart






share|improve this question















share|improve this question













share|improve this question




share|improve this question








edited 13 mins ago







vmp

















asked 28 mins ago









vmpvmp

14611




14611













  • can you post the code that does the foreach in foreach ?

    – Marius
    16 mins ago











  • Edited the original post

    – vmp
    12 mins ago



















  • can you post the code that does the foreach in foreach ?

    – Marius
    16 mins ago











  • Edited the original post

    – vmp
    12 mins ago

















can you post the code that does the foreach in foreach ?

– Marius
16 mins ago





can you post the code that does the foreach in foreach ?

– Marius
16 mins ago













Edited the original post

– vmp
12 mins ago





Edited the original post

– vmp
12 mins ago










0






active

oldest

votes











Your Answer








StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "479"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);

StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});

function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});


}
});














draft saved

draft discarded


















StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fmagento.stackexchange.com%2fquestions%2f258027%2fmagento-2-get-quantity-of-product-in-cart-without-loop%23new-answer', 'question_page');
}
);

Post as a guest















Required, but never shown

























0






active

oldest

votes








0






active

oldest

votes









active

oldest

votes






active

oldest

votes
















draft saved

draft discarded




















































Thanks for contributing an answer to Magento Stack Exchange!


  • Please be sure to answer the question. Provide details and share your research!

But avoid



  • Asking for help, clarification, or responding to other answers.

  • Making statements based on opinion; back them up with references or personal experience.


To learn more, see our tips on writing great answers.




draft saved


draft discarded














StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fmagento.stackexchange.com%2fquestions%2f258027%2fmagento-2-get-quantity-of-product-in-cart-without-loop%23new-answer', 'question_page');
}
);

Post as a guest















Required, but never shown





















































Required, but never shown














Required, but never shown












Required, but never shown







Required, but never shown

































Required, but never shown














Required, but never shown












Required, but never shown







Required, but never shown







Popular posts from this blog

Magento 2 controller redirect on button click in phtml file

Polycentropodidae